Skip to content

Conversation

CarsonF
Copy link
Member

@CarsonF CarsonF commented Mar 27, 2025

The goal here is to replace ProjectTypeFinancialApprover with one that is generic for all groups not just finance.
For example, we also have certain field approvers for internships & and consultant approvers for momentum.

I'm not exactly sure that the our organizational groups (Business::Group) capture this though.

  • Finance makes sense, and could apply to both FAs & LFAs (not constrained here, yet?).
  • FieldOps might be too coarse though. Consultants need to approve goal changes for momentum projects. Tonia needs to approve something for internships.

So many this group enum needs to be different. Like describing some business concept/process.


Anyways the schema is like this:

Project.approvers are all global approvers that match the project's program/type.
Project.approver is the approver for the current user, if any.

Project.isFinancialApprover is if the current user is an approver for the project type with the Finance group. Since this is a property it will be selected with * allowing the app to somewhat transparently get this auth info for our policy calculations.
This is actually on any ContextAware object, so there's also Engagement.isFinancialApprover, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant